Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zero/telemetry: calculate DAU and MAU #4810

Merged
merged 7 commits into from Dec 11, 2023
Merged

zero/telemetry: calculate DAU and MAU #4810

merged 7 commits into from Dec 11, 2023

Conversation

wasaga
Copy link
Contributor

@wasaga wasaga commented Dec 4, 2023

Summary

When running with Zero, in managed mode, periodically calculate DAU and MAU.
Note this PR does not include code to push those stats anywhere.

Related issues

Related: https://github.com/pomerium/pomerium-zero/issues/821

User Explanation

Checklist

  • reference any related issues
  • updated docs
  • updated unit tests
  • updated UPGRADING.md
  • add appropriate tag (improvement / bug / etc)
  • ready for review

@wasaga wasaga requested a review from a team as a code owner December 4, 2023 14:15
@coveralls
Copy link

coveralls commented Dec 4, 2023 •
edited

Coverage Status

coverage: 61.962% (-0.4%) from 62.332%
when pulling fd24e0e on wasaga/collect-active-users
into e0ac870 on main.

kenjenkins
kenjenkins reviewed Dec 5, 2023
View reviewed changes
internal/zero/analytics/activeusers.go Show resolved Hide resolved
internal/zero/controller/controller.go Outdated Show resolved Hide resolved
internal/zero/analytics/storage.go Show resolved Hide resolved
internal/zero/analytics/sessions.go Show resolved Hide resolved
internal/zero/analytics/sessions.go Outdated Show resolved Hide resolved
internal/zero/analytics/collector.go Show resolved Hide resolved
@wasaga wasaga merged commit c4dd965 into main Dec 11, 2023
12 checks passed
@wasaga wasaga deleted the wasaga/collect-active-users branch December 11, 2023 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenjenkins kenjenkins kenjenkins approved these changes

@calebdoxsey calebdoxsey Awaiting requested review from calebdoxsey

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@wasaga @coveralls @calebdoxsey @kenjenkins