core: fix graceful stop #4865
Merged
core: fix graceful stop #4865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wasaga
approved these changes
Dec 29, 2023
backport-actions-token bot
pushed a commit
that referenced
this pull request
Dec 29, 2023
* core/grpc: fix graceful stop * core/http: add graceful stop serve
calebdoxsey
added a commit
that referenced
this pull request
Dec 29, 2023
core: fix graceful stop (#4865) * core/grpc: fix graceful stop * core/http: add graceful stop serve Co-authored-by: Caleb Doxsey <cdoxsey@pomerium.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The current implementation of graceful stop for gRPC and HTTP doesn't work properly. It actually ends up shutting down immediately, but it was supposed to wait for 5 seconds to allow any active connections a chance to complete.
This PR adds two new
ServeWithGracefulStopfunctions for gRPC and HTTP that should behave as expected.Related issues
Fixes https://github.com/pomerium/internal/issues/1599
Checklist
improvement/bug/ etc)