authenticateflow: change how sessions are deleted #4893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The identity manager expects to be able to read session ID and user ID from any deleted databroker session records. The session.Delete() wrapper method is not compatible with this expectation, as it calls Put() with a record containing an empty session. The stateful authentication flow currently calls session.Delete() from its RevokeSession() method. The result is that the identity manager will not correctly track sessions deleted by the the stateful authentication flow, and will still try to use them during session refresh and user info refresh. Instead, let's change the stateful authentication flow RevokeSession() method to perform deletions in a way that is compatible with the current identity manager code. That is, include the existing session data in the Put() call to delete the revoked session.
calebdoxsey
reviewed
Jan 3, 2024
| // identity manager itself: fetch the existing databroker session record, | ||
| // explicitly set the DeletedAt timestamp, and Put() that record back. | ||
|
|
||
| res, err := s.dataBrokerClient.Get(ctx, &databroker.GetRequest{ |
There was a problem hiding this comment.
Can you use Patch instead?
There was a problem hiding this comment.
That's a good idea, but I think we can't, because the deleted_at field is part of the databroker Record message itself, rather than the data it contains (e.g. the Session message).
It might be worth a bigger conversation at some point about whether we should modify the Patch method to make it be able to delete a record.
calebdoxsey
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The identity manager expects to be able to read session ID and user ID from any deleted databroker session records. The
session.Delete()wrapper method is not compatible with this expectation, as it callsPut()with a record containing an empty session. The stateful authentication flow currently callssession.Delete()from itsRevokeSession()method.The result is that the identity manager will not correctly track sessions deleted by the the stateful authentication flow, and will still try to use them during session refresh and user info refresh.
Instead, let's change the stateful authentication flow
RevokeSession()method to perform deletions in a way that is compatible with the current identity manager code. That is, include the existing session data in thePut()call to delete the revoked session.Related issues
#4892
User Explanation
Checklist
improvement/bug/ etc)