core/databroker: disable identity manager user refresh when hosted authenticate is used #4905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If no
authenticate_service_urlis specified we switch to hosted authenticate mode. Hosted authenticate does not currently support user refresh, and user refresh is disabled if noidp_provideris specified. However if you specify anidp_providerwhile still using hosted authenticate, the identity manager will attempt to refresh the sessions, resulting in them being deleted after 10 minutes.This PR changes the identity manager to only enable user refresh if both an
idp_provideris set and hosted authenticate is not being used.Related issues
Checklist
improvement/bug/ etc)