envoyconfig: address strconv.Atoi warnings #5076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Replace Atoi() calls with ParseUint(), and update the buildAddress() defaultPort parameter to be a uint32. (A uint16 would arguably make more sense for a port number, but uint32 matches the Envoy proto field.) Delete a ParseAddress() method that appears to be unused.
kenjenkins
force-pushed
the
kenjenkins/int-atoi-warning
branch
from
3d97985
to
d4d18c4
Compare
calebdoxsey
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We recently enabled CodeQL scanning. This has flagged a few instances where we parse an integer using
strconv.Atoi()and then convert to auint32. Let's resolve these warnings by usingstrconv.ParseUint()instead, like @calebdoxsey did in 5b06b27.One of this instances is in a function that appears to be unused (GitHub search link), so let's go ahead and delete that function.
Related issues
User Explanation
Checklist
improvement/bug/ etc)