Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds upstream error page #5113

Merged
merged 2 commits into from
May 14, 2024
Merged

adds upstream error page #5113

merged 2 commits into from
May 14, 2024

Conversation

nhayfield
Copy link
Contributor

@nhayfield nhayfield commented May 14, 2024

Summary

Adds a different error page for routes that have an issue with the upstream connection

Related issues

Fixes https://github.com/pomerium/internal/issues/1782

User Explanation

Distinguishes between having an issue with your Pomerium config vs an error with an upstream provider

Checklist

  • reference any related issues
  • updated docs
  • updated unit tests
  • updated UPGRADING.md
  • add appropriate tag (improvement / bug / etc)
  • ready for review

@nhayfield nhayfield requested a review from a team as a code owner May 14, 2024 15:53
@nhayfield nhayfield added frontend javascript Pull requests that update Javascript code labels May 14, 2024
@nhayfield
Copy link
Contributor Author

upstreamErrorPage

@coveralls
Copy link

coveralls commented May 14, 2024

Coverage Status

coverage: 56.486% (-0.03%) from 56.512%
when pulling 0f02e58 on upstreamErrorPage
into 568e99f on main.

@desimone
Copy link
Contributor

Nice!

@ZPain8464
Copy link
Contributor

Agreed, this turned out nicely.

@nhayfield nhayfield merged commit adb5f78 into main May 14, 2024
16 checks passed
@nhayfield nhayfield deleted the upstreamErrorPage branch May 14, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants