authenticate: add jwks and .well-known endpoint #745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #745 +/- ##
========================================
- Coverage 75.0% 74.4% -0.6%
========================================
Files 58 59 +1
Lines 3154 3230 +76
========================================
+ Hits 2366 2404 +38
- Misses 638 670 +32
- Partials 150 156 +6
|
calebdoxsey
reviewed
May 21, 2020
Signed-off-by: Bobby DeSimone <bobbydesimone@gmail.com>
Signed-off-by: Bobby DeSimone <bobbydesimone@gmail.com>
calebdoxsey
approved these changes
May 21, 2020
authenticate/handlers.go
Outdated
| wellKnownURLS := struct { | ||
| // URL string referencing the client's JSON Web Key (JWK) Set | ||
| // RFC7517 document, which contains the client's public keys. | ||
| JSONWebWeySetURL string `json:"jwks_uri"` |
There was a problem hiding this comment.
typo: JSONWebWeySetURL should be JSONWebKeySetURL
docs/configuration/readme.md
Outdated
|
|
||
| If no certificate is specified, one will be generated for you and the base64'd public key will be added to the logs. | ||
| If no certificate is specified, one will be generated and the base64'd public key will be added to the logs. Note, hoever, that this key be unique to each service, ephemerial, and will not be accessible via the authenticate service's `jwks_uri` endpoint. |
There was a problem hiding this comment.
typo: hoever should be however, ephemerial should be ephemeral
There was a problem hiding this comment.
@calebdoxsey I'm having one of those days...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related issues
See also
Checklist: