Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake Support #10

Merged
merged 8 commits into from Oct 11, 2019
Merged

CMake Support #10

merged 8 commits into from Oct 11, 2019

Conversation

ksmit799
Copy link
Contributor

This PR adds initial CMake build support and removes the old VS2019 solution under the build folder. The SDK still won't compile under anything other than windows (due to dependencies on several windows libs) but a proper cross-platform build system is the first step. This also allows for easier building of shared/static libs.

Copy link
Owner

@pond3r pond3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally sounds like a good idea. Could you add a "Build Instructions" section to README.md with the recommended instructions to generate the binaries? (e.g. get this version of cmake, run this cmake command, etc). Thanks!

.gitignore Show resolved Hide resolved
@ksmit799
Copy link
Contributor Author

@pond3r I've added build instructions to the readme (windows only for the meantime). Let me know if you would like any further changes.

@pond3r pond3r merged commit c14ec56 into pond3r:master Oct 11, 2019
james7132 referenced this pull request in HouraiTeahouse/Backroll May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants