Support future end block #917
Conversation
| }); | ||
|
|
||
| switch (source.type) { | ||
| case "log": { | ||
| if (!isHistoricalSyncRequired) { | ||
| this.logFilterProgressTrackers[source.id] = new ProgressTracker({ | ||
| target: [startBlock, finalizedBlockNumber], | ||
| completed: [[startBlock, finalizedBlockNumber]], |
There was a problem hiding this comment.
This is what was causing the original issue with unfinalized start blocks
| @@ -342,6 +342,10 @@ export async function buildConfigAndIndexingFunctions({ | |||
| ? undefined | |||
| : endBlockMaybeNan; | |||
|
|
|||
| if (endBlock !== undefined && endBlock < startBlock) { | |||
| @@ -201,20 +199,15 @@ export class HistoricalSyncService extends Emittery<HistoricalSyncEvents> { | |||
| await Promise.all( | |||
| this.sources.map(async (source) => { | |||
| const { isHistoricalSyncRequired, startBlock, endBlock } = | |||
| validateHistoricalBlockRange({ | |||
| getHistoricalBlockRange({ | |||
|
|
||
| // "realtime" property may be undefined when `kill()` has been | ||
| // invoked but hasn't completed. | ||
| if (networkService.realtime === undefined) return; |
There was a problem hiding this comment.
Would it be simpler to just use ?. instead of !. above?
There was a problem hiding this comment.
There's actually two different things that can be undefined. networkService can be undefined depending on the result of .find(). However, it's an invariant that it will always be defined, which is why the ! is used.
The realtime property could be undefined if the case described in the comment occurs.
| realtimeSyncEvent.checkpoint.blockNumber > | ||
| networkService.realtime.endBlock | ||
| ) { | ||
| networkService.realtime.realtimeSync.kill(); |
There was a problem hiding this comment.
I think we should add an info log here: Synced final end block for '${network.name}' (${networkService.realtime.endBlock}), killing realtime sync service
| }); | ||
| const startBlock = source.startBlock; | ||
| const endBlock = source.endBlock ?? finalizedBlockNumber; | ||
| const isHistoricalSyncRequired = |
There was a problem hiding this comment.
We might be able to go one step further and consolidate the if (!isHistoricalSyncRequired) { ... logic from each branch below
Fixes several bugs pertaining to unfinalized start and end blocks
closes #813