Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to PyQt5 #44

Merged
merged 1 commit into from
Oct 18, 2018
Merged

Upgrade to PyQt5 #44

merged 1 commit into from
Oct 18, 2018

Conversation

xmarvin
Copy link
Contributor

@xmarvin xmarvin commented Sep 5, 2017

Hi!
I did some small upgrades to use your library with pyqt5.
Feel free to use it if you want.
Thanks

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 39.567% when pulling 957e324 on xmarvin:pyqt5 into 2730487 on ponty:master.

1 similar comment
@coveralls
Copy link

coveralls commented Sep 5, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.02%) to 39.567% when pulling 957e324 on xmarvin:pyqt5 into 2730487 on ponty:master.

@ponty
Copy link
Owner

ponty commented Sep 5, 2017

Thanks!
I will not merge this request, because it removes PyQt4 back-end.
PyQt5 back-end needs a new file: qt5grabwindow.py
You can send me new PR or I will create this file later.

@coveralls
Copy link

coveralls commented Sep 5, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.8%) to 38.774% when pulling 83c4b49 on xmarvin:pyqt5 into 2730487 on ponty:master.

@ponty ponty merged commit 83c4b49 into ponty:master Oct 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xmarvin @coveralls @ponty