Fix bug triggered by OpenSSL 3.2.0

.release-notes/openssl3.2.md

@@ -0,0 +1,3 @@
+## Fix bug triggered by OpenSSL 3.2
+
+Making HTTPClient calls over SSL when using OpenSSL 3.2.0 would encounter a nasty bug. When executed in a program compiled in release mode, the program would hang. When executed in a program compiled in debug mode, the program would segfault due to infinite recursion.

corral.json

@@ -2,7 +2,7 @@
   "deps": [
     {
       "locator": "github.com/ponylang/net_ssl.git",
-      "version": "1.3.1"
+      "version": "1.3.2"
     }
   ],
   "packages": [

http/_test.pony

@@ -11,6 +11,7 @@ actor \nodoc\ Main is TestList
   fun tag tests(test: PonyTest) =>
     _ClientErrorHandlingTests.make().tests(test)
     _ClientTests.make().tests(test)
+    _NetSSL105RegressionTests.make().tests(test)
 
     test(_Encode)
     test(_EncodeBad)

http/test_netssl_105_regression.pony

@@ -0,0 +1,48 @@
+use "pony_test"
+use "net"
+
+// Tests to verify that the ponylang/net_ssl #105 regression is fixed.
+// https://github.com/ponylang/net_ssl/issues/105
+// The expectation is that this test will pass if everything is good.
+// Otherwise, the test will segfault when compiled in debug mode or it will
+// hang if compled in release mode.
+actor \nodoc\ _NetSSL105RegressionTests is TestList
+  new make() =>
+    None
+
+  fun tag tests(test: PonyTest) =>
+    test(_NetSSL105RegressionTest)
+
+class \nodoc\ val _NetSSL105RegressionHandlerFactory is HandlerFactory
+  let _h: TestHelper
+
+  new create(h: TestHelper) =>
+    _h = h
+
+  fun box apply(session: HTTPSession tag): HTTPHandler ref^ =>
+    _NetSSL105RegressionHandler(_h)
+
+class \nodoc\ val _NetSSL105RegressionHandler is HTTPHandler
+  let _h: TestHelper
+
+  new create(h: TestHelper) =>
+     _h = h
+
+  fun ref apply(payload: Payload val): None tag =>
+    _h.complete(true)
+
+class \nodoc\ iso _NetSSL105RegressionTest is UnitTest
+  fun name(): String => "regression/net_ssl-105"
+
+  fun apply(h: TestHelper) =>
+    h.long_test(2_000_000_000)
+
+    try
+      let url = URL.build("https://echo.sacovo.ch")?
+      let auth = TCPConnectAuth(h.env.root)
+      let client = HTTPClient(auth)
+      let payload = Payload.request("GET", url)
+      client.apply(consume payload, _NetSSL105RegressionHandlerFactory(h))?
+    else
+      h.fail("Unable to setup test")
+    end