Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenGraph and Twitter cards statically #227

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Conversation

shaedrich
Copy link
Contributor

Fix #223

@ponylang-main ponylang-main added the discuss during sync Should be discussed during an upcoming sync label May 27, 2024
@shaedrich shaedrich changed the title Add OpenGraph and Twitter cards Add OpenGraph and Twitter cards statically May 27, 2024
shaedrich added a commit to shaedrich/pony-playground that referenced this pull request May 28, 2024
@jemc
Copy link
Member

jemc commented May 31, 2024

I prefer this simple approach over the one in PR #228.

I don't think we get much value from the dynamic titles/descriptions pulled from the tutorial.

@shaedrich
Copy link
Contributor Author

shaedrich commented May 31, 2024

Too bad, but I can't say, I didn't expect that.

However, the OpenGraph data will be a bit misleading then. We essentially wrongfully tell the people, getting the link preview, that they will get an "empty" playground editor and conceal the fact, that it will be prefilled with what is send along in the URL making this essentially a distinct page 🤷🏻

@shaedrich shaedrich marked this pull request as ready for review May 31, 2024 18:19
@jemc
Copy link
Member

jemc commented Jun 11, 2024

We essentially wrongfully tell the people, getting the link preview, that they will get an "empty" playground editor and conceal the fact, that it will be prefilled

Nothing about the description you wrote says or even implies that the editor they get to will be initially empty. So I don't think this is a problem in practice.

Let's merge it. 👍

@jemc jemc merged commit 42c46ea into ponylang:main Jun 11, 2024
7 checks passed
@ponylang-main ponylang-main removed the discuss during sync Should be discussed during an upcoming sync label Jun 11, 2024
@shaedrich
Copy link
Contributor Author

Nothing about the description you wrote says or even implies that the editor they get to will be initially empty.

Not explicitly, but implicitly as this is quite common.

@shaedrich shaedrich deleted the meta-tags branch June 12, 2024 03:28
@ponylang-main ponylang-main added the discuss during sync Should be discussed during an upcoming sync label Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss during sync Should be discussed during an upcoming sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Meta Tags, OpenGraph and Twitter Cards
3 participants