Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build the tutorial nightly to get alerts if it fails #522

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

SeanTAllen
Copy link
Member

@SeanTAllen SeanTAllen commented Dec 10, 2023

Currently, a person opening a PR can be surprised by failures unrelated
to their changes. In particular, to URLs that are external to the site
no longer working and failing validation.

Worse, this means that users of the tutorial are experiencing broken
URLs that won't be discovered until someone does an update for the
tutorial and the build fails.

This commit adds a nightly job that tries to build the site and if it
fails, alerts to Zulip so we can be made aware of issues in a timely
fashion and can endeavor to fix them as soon as possible.

The workflow can also be triggered manually if need be.

@ponylang-main ponylang-main added the discuss during sync Should be discussed during an upcoming sync label Dec 10, 2023
@SeanTAllen SeanTAllen force-pushed the build-nightly-to-find-busted branch 3 times, most recently from 0ff6ee9 to 932994f Compare December 10, 2023 05:16
@SeanTAllen SeanTAllen requested a review from a team December 10, 2023 05:17
Currently, a person opening a PR can be surprised by failures unrelated
to their changes. In particular, to URLs that are external to the site
no longer working and failing validation.

Worse, this means that users of the tutorial are experiencing broken
URLs that won't be discovered until someone does an update for the
tutorial and the build fails.

This commit adds a nightly job that tries to build the site and if it
fails, alerts to Zulip so we can be made aware of issues in a timely
fashion and can endeavor to fix them as soon as possible.

The workflow can also be triggered manually if need be.
Copy link
Member

@rhagenson rhagenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@SeanTAllen SeanTAllen marked this pull request as ready for review December 12, 2023 19:07
@SeanTAllen SeanTAllen merged commit 23ec447 into main Dec 12, 2023
11 checks passed
@SeanTAllen SeanTAllen deleted the build-nightly-to-find-busted branch December 12, 2023 19:08
@ponylang-main ponylang-main removed the discuss during sync Should be discussed during an upcoming sync label Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants