calling-c: elaborate on the x_dpy example #525
Conversation
The following code is not valid Pony code
let x_dpy = @XOpenDisplay(Pointer[U8])
ponylang-main
added
the
discuss during sync
| @@ -80,7 +80,8 @@ use @eglGetDisplay[Pointer[_EGLDisplayHandle]](disp: Pointer[_XDisplayHandle]) | |||
| primitive _XDisplayHandle | |||
| primitive _EGLDisplayHandle | |||
|
|
|||
| let x_dpy = @XOpenDisplay(Pointer[U8]) | |||
| let x_dpy_name: String = // ... | |||
There was a problem hiding this comment.
So the code here already "doesn't compile" as it isn't valid. I don't think this change makes things better.
I think that this could be slightly better if the string is given a realistic display name.
This could be made "much better" by taking all the C calling code and make it "real" by putting the "FFI code examples" in code that would at least compile.
|
@ponylang/committer I think the examples in this section are kind of a mess. They aren't valid code and leave alot for someone to guess how they are correct. I don't think that this change is helpful but I think it does highlight for me that the exmaples in this section are problematic. I'd prefer to kick out an issue to fix the "this is basically Pony pseudo code" issues in this section. If other committers feel this change is an improvement, we can both merge this and kick out an issue. |
|
Closed in favor of #526 |
ponylang-main
removed
the
discuss during sync
The following code is not valid Pony code