Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move "Match Expressions" and "As Operator" (in that order) into the "Expressions" section, between "Control Structures" and "Methods" #539

Merged
merged 6 commits into from
Apr 2, 2024
Merged

Move "Match Expressions" and "As Operator" (in that order) into the "Expressions" section, between "Control Structures" and "Methods" #539

merged 6 commits into from
Apr 2, 2024

Conversation

shaedrich
Copy link
Collaborator

@shaedrich shaedrich commented Mar 26, 2024 •
edited
Loading

Fix #536

As discussed in #536 (comment)

@shaedrich @jemc
Move "Match Expressions" and "As Operator" (in that order) into the "…
6a20c0e 
…Expressions" section, between "Control Structures" and "Methods"

As discussed in ponylang#536 (comment)

Co-authored-by: jemc <joe.eli.mac@gmail.com>
@ponylang-main ponylang-main added the discuss during sync Should be discussed during an upcoming sync label Mar 26, 2024
@SeanTAllen
Copy link
Member

This should include redirects from old location to new in netlify.toml

@SeanTAllen
Copy link
Member

There's errors on the build side with netlify:

https://app.netlify.com/sites/pony-tutorial/deploys/66032268a3fe2b0009664180

if some of those are internal links than rather than recovering with the redirects (which we want), it would be ideal to fix the internal links as well to go to the correct location rather than following a redirect.

shaedrich and others added 2 commits March 26, 2024 20:49
@shaedrich
Copy link
Collaborator Author

Should work now: https://deploy-preview-539--pony-tutorial.netlify.app/expressions/pattern-matching/

@SeanTAllen
Copy link
Member

The pattern matching subdirectory should be removed and the overview deleted.

That was the intent. Sorry that wasn't communicated more clearly.

@shaedrich
Remove index and extra level of indention
f9196e7 
Co-authored-by: SeanTAllen <sean@seantallen.com>

As requested per ponylang#539 (comment)
@shaedrich
Copy link
Collaborator Author

Yeah, sorry, I wasn't sure. But no problem, it's fixed now.

SeanTAllen
SeanTAllen reviewed Mar 27, 2024
View reviewed changes
netlify.toml Outdated Show resolved Hide resolved
@SeanTAllen
Copy link
Member

One more small change. Sorry @shaedrich. Thanks for your work on this.

@shaedrich @SeanTAllen
Split the generic redirects to specific ones
a8ead55 
As requested in ponylang#539 (comment)

Co-authored-by: SeanTAllen <sean@seantallen.com>
@shaedrich
Copy link
Collaborator Author

shaedrich commented Mar 27, 2024 •
edited
Loading

No trouble at all. You're welcome, @SeanTAllen.

@SeanTAllen
Copy link
Member

Thanks @shaedrich

@SeanTAllen SeanTAllen merged commit dc2562b into ponylang:main Apr 2, 2024
8 checks passed
@ponylang-main ponylang-main removed the discuss during sync Should be discussed during an upcoming sync label Apr 2, 2024
@shaedrich
Copy link
Collaborator Author

My pleasure, @SeanTAllen

@shaedrich shaedrich deleted the patch-3 branch April 2, 2024 19:18
@ponylang-main ponylang-main added the discuss during sync Should be discussed during an upcoming sync label Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeanTAllen SeanTAllen SeanTAllen left review comments

Assignees
No one assigned
Labels
discuss during sync Should be discussed during an upcoming sync
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tutorial chapter order
3 participants
@shaedrich @SeanTAllen @ponylang-main