Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta Tags, OpenGraph and Twitter Cards #548

Closed
wants to merge 20 commits into from

Conversation

shaedrich
Copy link
Collaborator

Fixes #546

@ponylang-main ponylang-main added the discuss during sync Should be discussed during an upcoming sync label May 24, 2024
Copy link

netlify bot commented May 24, 2024

Deploy Preview for pony-tutorial ready!

Name Link
🔨 Latest commit 80259c2
🔍 Latest deploy log https://app.netlify.com/sites/pony-tutorial/deploys/665fc94a4ee772000785ad46
😎 Deploy Preview https://deploy-preview-548--pony-tutorial.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shaedrich
Copy link
Collaborator Author

Result: 😍
grafik

@SeanTAllen
Copy link
Member

SeanTAllen commented May 31, 2024

One of my favorite things about when we moved from the Hugo theme I did that supported meta tags and twitter cards was that we didn't have to try to come up with descriptions for every page. It was a slog in some cases.

We will discuss at sync and perhaps other maintainers will see the value. I personally have been down the road of this already with our old setup and I didn't see the value in it. It was just extra work, extra stuff to maintain so I'm not in favor, but others might be.

Will update further after our next sync call.

Thanks for opening this PR Sebastian. Your commitment to improving the tutorial has been impressive and inspiring to watch as the updates flow into my inbox.

@shaedrich
Copy link
Collaborator Author

One of my favorite things about when we moved from the Hugo theme I did that supported meta tags and twitter cards was that we didn't have to try to come up with descriptions for every page. It was a slog in some cases.

You unfortunaly see it from a slightly "wrong" angle. I totally see, that you don't want to write these descriptions. But I wouldn't call a SSG engine "better" when it is lacking a fairly standard feature, just because I personally don't like the work that goes into it and I, unlike many other people, don't use that feature.

Sorry if I'm out of line here.

@SeanTAllen
Copy link
Member

Can the title come from the H1 in the page? Having in metadata, it could get out of sync.

@shaedrich
Copy link
Collaborator Author

shaedrich commented Jun 4, 2024

Can the title come from the H1 in the page? Having in metadata, it could get out of sync.

It could. However, as you see, this works fine on page but less so more often than not taken out of context as it will be when sent as a link.

@SeanTAllen
Copy link
Member

It could. However, as you see, this works fine on page but less so more often than not taken out of context as it will be when sent as a link.

Can it come from the existing breadcrumb stuff in mkdocs?

@jemc
Copy link
Member

jemc commented Jun 4, 2024

I'm in agreement with @SeanTAllen on this point.

I admit that having page-specific information in the Card can be useful for someone glancing quickly card but it's a fairly small amount of value and I don't think it outweighs the maintenance effort being added.

Here are my concrete set of concerns:

  • the problem of drift between in the title in the metadata vs the title in the H1
  • the problem of drift between chapter title in the metadata vs the actual title of the containing chapter
  • the problem where all these meta fields are hidden during normal browsing, and someone may not notice that they need to update them when only looking at the static site in the netlify preview.
  • the description copy, being hidden may not get as much attention as it perhaps should during maintenance

Some alternative ideas discussed in sync:

  • try to pull the title info from the H1 and the chapter title, instead of duplicating that info
  • use a generic description for the entire tutorial, or perhaps a per-chapter description as a compromise.

@SeanTAllen SeanTAllen removed the discuss during sync Should be discussed during an upcoming sync label Jun 4, 2024
@shaedrich
Copy link
Collaborator Author

shaedrich commented Jun 5, 2024

Maybe, I didn't explain my concerns in a reasonable way: For example: Do you know how many pages named "Overview" we have? Quite a few, actually. This raises the question: Overview of what? So, this gives the user essentially nothing. Does that make it a little clearer?

It could. However, as you see, this works fine on page but less so more often than not taken out of context as it will be when sent as a link.

Can it come from the existing breadcrumb stuff in mkdocs?

@SeanTAllen Sounds good 👍🏻 I made the necessary changes

perhaps a per-chapter description as a compromise

@jemc This isn't really a compromise. This essentially has the same problem as a generic description for the entire tutorial. It doesn't say what's on the page. I wouldn't go as far as saying that this way we lie to the user but we get close to it by not telling them where the link actually leads to and instead claim, the entire chapter was just one page.

And as you were worried about Google/SEO: I'm not entirely sure how Google actually determines that but multiple pages with the same description could be seen as "duplicate content", which that would have a negative impact on the SEO.

@ponylang-main ponylang-main added the discuss during sync Should be discussed during an upcoming sync label Jun 5, 2024
@jemc jemc removed the discuss during sync Should be discussed during an upcoming sync label Jun 25, 2024
@shaedrich
Copy link
Collaborator Author

See #546 (comment)

@shaedrich shaedrich closed this Jun 30, 2024
@ponylang-main ponylang-main added the discuss during sync Should be discussed during an upcoming sync label Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss during sync Should be discussed during an upcoming sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Meta Tags, OpenGraph and Twitter Cards
4 participants