Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
added count and offset to search api (#232)
- Loading branch information
Showing
2 changed files
with
24 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4ce9a46
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@torniker - I wanted to merge this in as-is, but I'll still comment here. We could also support the
order
param by switching on itsstrings.ToLower(offset)
value forasc
anddesc
, then using the existing range fordesc
, or in reverse for theasc
direction. By default, Bleve has adesc
sort order. I don't know if Bleve's ordering is done by time, but we would simply be reversing the order, which is what a user typically wants anyways.This way both the content and search APIs have parity in their selection options.
What do you think?