uploads folder is full of trash files

[nanohard]

Whenever I create a content item I get an empty file in the uploads folder.
Why does this happen?
Is it possible to prevent this from happening so that only files > 0 bytes are put there?

Edit:
I have discovered that the filenames are timestamps. But why do they exists?

[nilslice]

Hey, it is definitely possible but would require a patch that I have not had time to PR.

I'm not at my computer at the moment, but if you're interested in looking there's an upload.go file (I believe) where you'd likely check the byte length of the multipart fields and ignore anything that is == 0.

I would like to change the API a bit before v1 so that only multipart encoded form requests even go down the path of an upload and enable create/update requests to be in any other encoding. That would be an awesome PR if you are interested...

[nanohard]

I could only implement a workaround to not show the zero-byte files in the GUI. I could not figure out how to get the files to not be created.

I think in order to do this several functions will have to be split up. As it stands now, it seems like the functions in question will only write to the database if the file is created. So- no file, no database entry.

This means that content cannot be created without a timestamped file being created first, which needs to be split out of the functions and made to be a separate, optional, operation.

Edit:
The reason content creation creates an empty file is in the case of adding a file to content. When a file is attached to content, the file is named [timestamp]-[filename].
When no file is attached to content, the file is named [timestamp]-, with just a dash at the end.
The easiest thing to do then, although sloppy, would be to see if the last character of the file is a dash (-) and then delete the file after creation when creating/editing content.

Ideally though, these functions would be rewritten.

[nanohard]

Files and functions that are involved:

• system/admin/handlers.go
  • editHandler() (calls on storeFiles() 1 time)
  • editUploadHandler() (calls on storeFiles() 3 times)
• system/admin/upload/upload.go
  • storeFiles()

Perhaps, if storeFiles() is aptly named, then we can then just focus on editHandler() and editUploadHandler() and split out the calls to storeFiles() to call on only if actually storing a file. I'll have to actually read the code and see if storeFiles() triggers a database call. The file upload and save to database need to be mutually exclusive.

[olliephillips]

Thought I would take a look at this, but I can not replicate this behaviour. Fixed already? Anyone else see empty files created? I see folders, but not files.

[olliephillips]

Closing this on the basis that it is now old and I could not replicate - either with file or filerepeater. It may have been addressed. Please re-open if anyone finds this to still be an issue.