Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go module support #344

Closed
RPing opened this issue Apr 26, 2020 · 9 comments
Closed

go module support #344

RPing opened this issue Apr 26, 2020 · 9 comments

Comments

@RPing
Copy link

RPing commented Apr 26, 2020

Some dependency latest version enforced go module support, like bleve
blevesearch/bleve#1373

So build ponzu, that is GO111MODULE=off ponzu build,
the following error occurs:

$ GO111MODULE=off ponzu build
../../blevesearch/bleve/index/scorch/segment_plugin.go:22:2: cannot find package "github.com/blevesearch/zap/v11" in any of:
	/usr/local/go/src/github.com/blevesearch/zap/v11 (from $GOROOT)
	/home/rpchen1228/go/src/github.com/blevesearch/zap/v11 (from $GOPATH)
Error: exit status 1
Usage:
  ponzu build [flags]

Examples:
$ ponzu build
(or)
$ ponzu build --gocmd=go1.8rc1

Flags:
  -h, --help   help for build

Global Flags:
      --gocmd string   custom go command if using beta or new release of Go (default "go")

exit status 1

@nilslice
Copy link
Contributor

It would make a great PR :)

@dmitridb
Copy link

dmitridb commented May 4, 2020

I don't really see this in the docs or anything but all I really had to do in order to get this up was vendoring the dependencies into what I was doing. So as follows, for an example:

git init
go mod init github.com/dmitridb/ponzu-example
go mod vendor
ponzu build

@olliephillips
Copy link
Contributor

olliephillips commented May 13, 2020

Edit : I just misread your comment, you are building the server.

@dmitridb That's a good shout but the dependency piece is more about how Ponzu builds the ponzu server binary internally I think. It's been historically dependent on GOPATH, and does not reference go.mod. I'm pretty sure that's the case. Bit rusty myself TBH.

@dmitridb
Copy link

Yeah they really fixed all of that in recent version of golang it's pretty nice tbh

@dmitridb
Copy link

People were using all sorts of insane stuff before like gopkg.in or whatever so it's nice that they unified things

@saeed-golshan
Copy link

saeed-golshan commented Mar 20, 2021

I have this problem too when I do this:
git init go mod init github.com/dmitridb/ponzu-example go mod vendor ponzu build
no content appeared when I make some content

@Avarsa
Copy link

Avarsa commented Apr 17, 2021

I have this problem too when I do this:
git init go mod init github.com/dmitridb/ponzu-example go mod vendor ponzu build
no content appeared when I make some content

Same. Unable to see any content here. What could be happening here?

@dmitridb
Copy link

dmitridb commented Apr 17, 2021 via email

@ponzu-cms ponzu-cms locked as too heated and limited conversation to collaborators Apr 17, 2021
@olliephillips
Copy link
Contributor

The project isn’t maintained anymore. Modules support isn’t there, and probably won’t ever be, unless someone forks the project and implements modules that’s where things are.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants