Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Just a little cleaner code #35

Merged
merged 1 commit into from Jan 20, 2017
Merged

Conversation

crackcomm
Copy link
Contributor

I did it during reading the code.

@nilslice
Copy link
Contributor

@crackcomm - hi, thank you for sending! Will look through this asap.

@nilslice
Copy link
Contributor

This is all great - thx. sorry I didn't have it online, but would you re-push this to the ponzu-dev branch? I have made a commit or too since the last version available too, which are in the new branch.

@crackcomm crackcomm changed the base branch from master to ponzu-dev January 20, 2017 08:07
@crackcomm
Copy link
Contributor Author

I've read contributing section but forgot about that, I changed it.

@nilslice
Copy link
Contributor

Thank you! I wasn't aware that I could edit the base branch for this commit. learn something new every day..

Once I run through some tests I will merge - I think I generally want to keep with the '&' syntax rather than 'new' -- unless you suggest a particular reason for 'new'? see: https://github.com/ponzu-cms/ponzu/pull/35/files#diff-6fdb1e817a428df8132da1d23cb983ceR146 I will go through and make those updates though. I contradict myself in the addon and content generator template code - but I think it makes it more obvious that the function returns a new pointer..

@nilslice nilslice merged commit 76c64e7 into ponzu-cms:ponzu-dev Jan 20, 2017
@crackcomm
Copy link
Contributor Author

I just find it a much cleaner way to create a new empty structure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants