more tests

pooltogether · Aug 31, 2021 · ea19e3a · ea19e3a
1 parent 9ed07d5
commit ea19e3a
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 3 deletions.
diff --git a/contracts/test/OwnerOrManagerHarness.sol b/contracts/test/OwnerOrManagerHarness.sol
@@ -7,6 +7,8 @@ import "hardhat/console.sol";
 
 contract OwnerOrManagerHarness is OwnerOrManager {
 
+    event ReallyCoolEvent(address);
+
     constructor() public {
         __Ownable_init();
 
@@ -16,6 +18,9 @@ contract OwnerOrManagerHarness is OwnerOrManager {
     function protectedFunction() public onlyManagerOrOwner {
 
         // do admin priviledges things
+
+
+        emit ReallyCoolEvent(msg.sender);
     }
 
 }
diff --git a/test/OwnerOrManager.test.ts b/test/OwnerOrManager.test.ts
@@ -1,8 +1,6 @@
 import { expect } from 'chai';
-import { deployMockContract, MockContract } from 'ethereum-waffle';
 import { Contract, ContractFactory, Signer, Wallet } from 'ethers';
 import { ethers } from 'hardhat';
-import { Interface } from 'ethers/lib/utils';
 import { SignerWithAddress } from '@nomiclabs/hardhat-ethers/signers';
 
 describe('Test Set Name', () => {
@@ -24,9 +22,19 @@ describe('Test Set Name', () => {
     })
 
     describe("onlyManagerOrOwner()", ()=>{
-        it('permissions correctly', async () => {
+        it('non owner non manager cannot call permissioned function', async () => {
             await expect(ownerOrManager.connect(wallet3).protectedFunction()).to.be.revertedWith("Manager/caller-not-manager-or-owner")       
         })
+
+        it('non owner non manager cannot call permissioned function', async () => {
+            await expect(ownerOrManager.protectedFunction()).to.emit(ownerOrManager, "ReallyCoolEvent")  
+            await ownerOrManager.setManager(wallet2.address)      
+            await expect(ownerOrManager.connect(wallet2).protectedFunction()).to.emit(ownerOrManager, "ReallyCoolEvent")
+        })
+
+        it('manager cannot set new manage', async ()=> {
+            await expect(ownerOrManager.connect(wallet2).protectedFunction()).to.be.reverted
+        })
     })
 
 })