Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests #1

Merged
merged 16 commits into from
May 5, 2021
Merged

Add unit tests #1

merged 16 commits into from
May 5, 2021

Conversation

aodhgan
Copy link
Contributor

@aodhgan aodhgan commented Apr 28, 2021

No description provided.

contracts/PodsUpkeep.sol Outdated Show resolved Hide resolved
contracts/PodsUpkeep.sol Outdated Show resolved Hide resolved
contracts/PodsUpkeep.sol Outdated Show resolved Hide resolved
contracts/PodsUpkeep.sol Outdated Show resolved Hide resolved
contracts/PodsUpkeep.sol Outdated Show resolved Hide resolved
contracts/PodsUpkeep.sol Outdated Show resolved Hide resolved
contracts/PodsUpkeep.sol Outdated Show resolved Hide resolved
contracts/PodsUpkeep.sol Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
contracts/PodsUpkeep.sol Outdated Show resolved Hide resolved
contracts/PodsUpkeep.sol Outdated Show resolved Hide resolved
contracts/PodsUpkeep.sol Outdated Show resolved Hide resolved
contracts/PodsUpkeep.sol Outdated Show resolved Hide resolved
@asselstine
Copy link
Contributor

For a good example of packing data into a word you can check out the merkle distributor. It packs multiple booleans into a single word.

contracts/PodsUpkeep.sol Outdated Show resolved Hide resolved
@asselstine
Copy link
Contributor

Quality is looking good! Just a little bit to trim

Copy link
Contributor

@asselstine asselstine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor trim, but otherwise good

contracts/test/TestPod.sol Outdated Show resolved Hide resolved
contracts/interfaces/IPod.sol Outdated Show resolved Hide resolved
@aodhgan aodhgan merged commit 42bee28 into master May 5, 2021
@aodhgan aodhgan deleted the add_unit_tests branch May 5, 2021 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants