OZ Audit Issue N01: Update yVaultInterface#token() to return IERC20 i…

…nterface (#206) * Fixed underflow in captureAwardBalance * Fixes OZ Audit 2 issues M01 and L02 * Update yVaultInterface#token() to return IERC20 interface
pooltogether · Nov 30, 2020 · a65c64a · a65c64a
1 parent b970058
commit a65c64a
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/contracts/external/yearn/yVaultInterface.sol b/contracts/external/yearn/yVaultInterface.sol
@@ -3,7 +3,7 @@ pragma solidity >=0.6.0 <0.7.0;
 import "@openzeppelin/contracts-ethereum-package/contracts/token/ERC20/IERC20.sol";
 
 interface yVaultInterface is IERC20 {
-    function token() external view returns (address);
+    function token() external view returns (IERC20);
 
     function balance() external view returns (uint);
 

diff --git a/contracts/prize-pool/yearn/yVaultPrizePool.sol b/contracts/prize-pool/yearn/yVaultPrizePool.sol
@@ -95,7 +95,7 @@ contract yVaultPrizePool is PrizePool {
   /// @param _externalToken The address of the token to check
   /// @return True if the token may be awarded, false otherwise
   function _canAwardExternal(address _externalToken) internal override view returns (bool) {
-    return _externalToken != address(vault) && _externalToken != vault.token();
+    return _externalToken != address(vault) && _externalToken != address(vault.token());
   }
 
   /// @dev Allows a user to redeem yield-bearing tokens in exchange for the underlying

diff --git a/contracts/test/yVaultMock.sol b/contracts/test/yVaultMock.sol
@@ -15,8 +15,8 @@ contract yVaultMock is yVaultInterface, ERC20UpgradeSafe {
     vaultFeeMantissa = 0.05 ether;
   }
 
-  function token() external override view returns (address) {
-    return address(asset);
+  function token() external override view returns (IERC20) {
+    return asset;
   }
 
   function balance() public override view returns (uint) {