Fixes as per review comments

pooltogether · Jun 19, 2020 · ca01771 · ca01771
1 parent b9e0e6e
commit ca01771
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/contracts/token/ControlledToken.sol b/contracts/token/ControlledToken.sol
@@ -29,10 +29,6 @@ contract ControlledToken is ERC777UpgradeSafe, BaseRelayRecipient {
     _burn(_user, _amount, data, operatorData);
   }
 
-  // function burn(uint256 amount, bytes memory data) public override  {
-  //   revert();
-  // }
-
   modifier onlyController {
     require(_msgSender() == address(controller), "only controller");
     _;

diff --git a/package.json b/package.json
@@ -11,7 +11,7 @@
     "test": "buidler test",
     "compile": "buidler --show-stack-traces --max-memory 8192 compile",
     "start": "buidler node --port $LOCAL_BUIDLEREVM_PORT",
-    "coverage": "rm -rf build cache test-results.xml && buidler compile && buidler coverage --network coverage --temp build",
+    "coverage": "rm -rf build cache test-results.xml && buidler compile && buidler coverage --network coverage --temp build; rm -rf cache",
     "gas": "REPORT_GAS=true buidler test --network local",
     "migrate": "./scripts/cli.js",
     "migrate-local": "oz compile; ./scripts/cli.js migrate -n local -a $LOCAL_ADMIN_ADDRESS",

diff --git a/test/PeriodicPrizePool.test.js b/test/PeriodicPrizePool.test.js
@@ -99,6 +99,11 @@ describe.only('PeriodicPrizePool contract', function() {
       expect(await prizePool.ticketCredit()).to.equal(ticketCredit.address)
       expect(await prizePool.sponsorshipCredit()).to.equal(sponsorshipCredit.address)
     })
+
+    it('should not allow setting the token addresses twice', async () => {
+      await expect(prizePool.setTokens(ticket.address, sponsorship.address, ticketCredit.address, sponsorshipCredit.address))
+        .to.be.revertedWith('already initialized')
+    })
   })
 
   describe('supplySponsorship()', () => {