N02: Explicitly delete addresses in MappedSinglyLinkedList #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
POOL-395 OZ Audit N02
In the |
asselstine
changed the title
* Added comments clarifying an edge case for timelocked funds * N05: Made return variable naming consistent (#113) * Made return variable naming consistent All functions have explicit return statements Functions that have a single return value won't name the value Functions that have two or more returns value will have named returns * Fixed some spelling mistakes (#114)
asselstine
added a commit
that referenced
this pull request
Aug 21, 2020
* Improved language consistency * N02: Explicitly delete addresses in MappedSinglyLinkedList (#111) * Explicitly delete addresses in MappedSinglyLinkedList * N03: Added comments clarifying an edge case for timelocked funds (#112) * Added comments clarifying an edge case for timelocked funds * N05: Made return variable naming consistent (#113) * Made return variable naming consistent All functions have explicit return statements Functions that have a single return value won't name the value Functions that have two or more returns value will have named returns * Fixed some spelling mistakes (#114)
asselstine
added a commit
that referenced
this pull request
Aug 21, 2020
* Made PrizePool field naming more consistent * N01: Improved language consistency (#110) * Improved language consistency * N02: Explicitly delete addresses in MappedSinglyLinkedList (#111) * Explicitly delete addresses in MappedSinglyLinkedList * N03: Added comments clarifying an edge case for timelocked funds (#112) * Added comments clarifying an edge case for timelocked funds * N05: Made return variable naming consistent (#113) * Made return variable naming consistent All functions have explicit return statements Functions that have a single return value won't name the value Functions that have two or more returns value will have named returns * Fixed some spelling mistakes (#114)
asselstine
added a commit
that referenced
this pull request
Aug 21, 2020
* Improved interface of MappedSinglyLinkedList * Fixed typo straggler * L06: Made PrizePool field naming more consistent (#109) * Made PrizePool field naming more consistent * N01: Improved language consistency (#110) * Improved language consistency * N02: Explicitly delete addresses in MappedSinglyLinkedList (#111) * Explicitly delete addresses in MappedSinglyLinkedList * N03: Added comments clarifying an edge case for timelocked funds (#112) * Added comments clarifying an edge case for timelocked funds * N05: Made return variable naming consistent (#113) * Made return variable naming consistent All functions have explicit return statements Functions that have a single return value won't name the value Functions that have two or more returns value will have named returns * Fixed some spelling mistakes (#114)
asselstine
added a commit
that referenced
this pull request
Aug 21, 2020
* Emit event when PrizePool adds a controlled token * L05: Improved interface of MappedSinglyLinkedList (#108) * Improved interface of MappedSinglyLinkedList * Fixed typo straggler * L06: Made PrizePool field naming more consistent (#109) * Made PrizePool field naming more consistent * N01: Improved language consistency (#110) * Improved language consistency * N02: Explicitly delete addresses in MappedSinglyLinkedList (#111) * Explicitly delete addresses in MappedSinglyLinkedList * N03: Added comments clarifying an edge case for timelocked funds (#112) * Added comments clarifying an edge case for timelocked funds * N05: Made return variable naming consistent (#113) * Made return variable naming consistent All functions have explicit return statements Functions that have a single return value won't name the value Functions that have two or more returns value will have named returns * Fixed some spelling mistakes (#114)
asselstine
added a commit
that referenced
this pull request
Aug 21, 2020
* Added initialize protection to MappedSinglyLinkedList * L04: Emit event when PrizePool adds a controlled token (#107) * Emit event when PrizePool adds a controlled token * L05: Improved interface of MappedSinglyLinkedList (#108) * Improved interface of MappedSinglyLinkedList * Fixed typo straggler * L06: Made PrizePool field naming more consistent (#109) * Made PrizePool field naming more consistent * N01: Improved language consistency (#110) * Improved language consistency * N02: Explicitly delete addresses in MappedSinglyLinkedList (#111) * Explicitly delete addresses in MappedSinglyLinkedList * N03: Added comments clarifying an edge case for timelocked funds (#112) * Added comments clarifying an edge case for timelocked funds * N05: Made return variable naming consistent (#113) * Made return variable naming consistent All functions have explicit return statements Functions that have a single return value won't name the value Functions that have two or more returns value will have named returns * Fixed some spelling mistakes (#114)
asselstine
added a commit
that referenced
this pull request
Aug 21, 2020
…entinel (#105) * Ensured that MappedSinglyLinkedList#contains returns false for Sentinel * L03: Feature/pool 390 oz audit l03 (#106) * Added initialize protection to MappedSinglyLinkedList * L04: Emit event when PrizePool adds a controlled token (#107) * Emit event when PrizePool adds a controlled token * L05: Improved interface of MappedSinglyLinkedList (#108) * Improved interface of MappedSinglyLinkedList * Fixed typo straggler * L06: Made PrizePool field naming more consistent (#109) * Made PrizePool field naming more consistent * N01: Improved language consistency (#110) * Improved language consistency * N02: Explicitly delete addresses in MappedSinglyLinkedList (#111) * Explicitly delete addresses in MappedSinglyLinkedList * N03: Added comments clarifying an edge case for timelocked funds (#112) * Added comments clarifying an edge case for timelocked funds * N05: Made return variable naming consistent (#113) * Made return variable naming consistent All functions have explicit return statements Functions that have a single return value won't name the value Functions that have two or more returns value will have named returns * Fixed some spelling mistakes (#114)
asselstine
added a commit
that referenced
this pull request
Aug 21, 2020
* Removed redundant code * L02: Ensured that MappedSinglyLinkedList#contains returns false for Sentinel (#105) * Ensured that MappedSinglyLinkedList#contains returns false for Sentinel * L03: Feature/pool 390 oz audit l03 (#106) * Added initialize protection to MappedSinglyLinkedList * L04: Emit event when PrizePool adds a controlled token (#107) * Emit event when PrizePool adds a controlled token * L05: Improved interface of MappedSinglyLinkedList (#108) * Improved interface of MappedSinglyLinkedList * Fixed typo straggler * L06: Made PrizePool field naming more consistent (#109) * Made PrizePool field naming more consistent * N01: Improved language consistency (#110) * Improved language consistency * N02: Explicitly delete addresses in MappedSinglyLinkedList (#111) * Explicitly delete addresses in MappedSinglyLinkedList * N03: Added comments clarifying an edge case for timelocked funds (#112) * Added comments clarifying an edge case for timelocked funds * N05: Made return variable naming consistent (#113) * Made return variable naming consistent All functions have explicit return statements Functions that have a single return value won't name the value Functions that have two or more returns value will have named returns * Fixed some spelling mistakes (#114)
asselstine
added a commit
that referenced
this pull request
Aug 21, 2020
* Fixed weak initialization in MappedSinglyLinkedList * L01: Removed redundant code (#104) * Removed redundant code * L02: Ensured that MappedSinglyLinkedList#contains returns false for Sentinel (#105) * Ensured that MappedSinglyLinkedList#contains returns false for Sentinel * L03: Feature/pool 390 oz audit l03 (#106) * Added initialize protection to MappedSinglyLinkedList * L04: Emit event when PrizePool adds a controlled token (#107) * Emit event when PrizePool adds a controlled token * L05: Improved interface of MappedSinglyLinkedList (#108) * Improved interface of MappedSinglyLinkedList * Fixed typo straggler * L06: Made PrizePool field naming more consistent (#109) * Made PrizePool field naming more consistent * N01: Improved language consistency (#110) * Improved language consistency * N02: Explicitly delete addresses in MappedSinglyLinkedList (#111) * Explicitly delete addresses in MappedSinglyLinkedList * N03: Added comments clarifying an edge case for timelocked funds (#112) * Added comments clarifying an edge case for timelocked funds * N05: Made return variable naming consistent (#113) * Made return variable naming consistent All functions have explicit return statements Functions that have a single return value won't name the value Functions that have two or more returns value will have named returns * Fixed some spelling mistakes (#114)
asselstine
added a commit
that referenced
this pull request
Aug 21, 2020
* Removed sponsored instant withdrawals This can easily be done with a simple token transfer * M01 + N04: Fixed weak initialization in MappedSinglyLinkedList (#103) * Fixed weak initialization in MappedSinglyLinkedList * L01: Removed redundant code (#104) * Removed redundant code * L02: Ensured that MappedSinglyLinkedList#contains returns false for Sentinel (#105) * Ensured that MappedSinglyLinkedList#contains returns false for Sentinel * L03: Feature/pool 390 oz audit l03 (#106) * Added initialize protection to MappedSinglyLinkedList * L04: Emit event when PrizePool adds a controlled token (#107) * Emit event when PrizePool adds a controlled token * L05: Improved interface of MappedSinglyLinkedList (#108) * Improved interface of MappedSinglyLinkedList * Fixed typo straggler * L06: Made PrizePool field naming more consistent (#109) * Made PrizePool field naming more consistent * N01: Improved language consistency (#110) * Improved language consistency * N02: Explicitly delete addresses in MappedSinglyLinkedList (#111) * Explicitly delete addresses in MappedSinglyLinkedList * N03: Added comments clarifying an edge case for timelocked funds (#112) * Added comments clarifying an edge case for timelocked funds * N05: Made return variable naming consistent (#113) * Made return variable naming consistent All functions have explicit return statements Functions that have a single return value won't name the value Functions that have two or more returns value will have named returns * Fixed some spelling mistakes (#114)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.