Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/pool 379 make the prize start time configurable #115

Merged

Conversation

robsecord
Copy link
Contributor

No description provided.

contracts/prize-strategy/PrizeStrategy.sol Outdated Show resolved Hide resolved
contracts/prize-strategy/PrizeStrategy.sol Outdated Show resolved Hide resolved
contracts/prize-strategy/PrizeStrategy.sol Outdated Show resolved Hide resolved
Copy link
Contributor

@asselstine asselstine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's with the coverage drop? Seems like something is getting skipped

@robsecord robsecord merged commit a733c70 into version-3 Aug 18, 2020
@robsecord robsecord deleted the feature/pool-379-make-the-prize-start-time-configurable branch August 18, 2020 15:45
robsecord pushed a commit that referenced this pull request Sep 9, 2020
* Add integration tests for exit-fees with very large amounts, clean-up the calculation for early exit-fees (#94)
* Feature/pool 368 configure the deployment (#96)
* Updated buidler and ethers
* Setup deployment environment
- Comptroller is upgradeable and has admin
- Remaining contracts are static
* Fixed up buidler config to make it more robust
* Fixed coverage issues
* Feature/pool 355 remaining items to test (#98)
* Updates to tests for Prize Strategy
* Further updates to tests for Prize Strategy
* Remove duplicate code
* Fix require statements
* Add various unit-tests
* Update sum-tree after prize awarded (#97)
* Update sum-tree after prize awarded
* Update tests to ensure sum-tree is updated
* Collapsed Referrals and Standard Volume Drips (#99)
- Comptroller now simply has a volume drip list
- volume drip events are now sane
* Feature/pool 402 update integration with latest rng (#116)
* Feature/pool 379 make the prize start time configurable (#115)
* Allow specifying RNG service during PrizePool creation (#117)
Refactor time-based mgmt in integration tests
* Update deployments
* Update Readme
* v3.0.0-alpha.30
* Refactored the Balance drip so that claims would be global (#122)
* Refactored the Balance drip so that claims would be global
* PR fixes
* Feature/pool 419 refactor volume drips so that the claim (#123)
* Refactored volume drips
- Volume drips now accrue to a global drip token claim balance
- Volume drips are now locked to measure,dripToken pairs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants