R02: Feature/pool 408 refactor credit accrual into prize pool #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asselstine
changed the title
asselstine
changed the title
robsecord
reviewed
Sep 8, 2020
| /// @param amount The amount the user is withdrawing | ||
| /// @param controlledToken The type of collateral the user is withdrawing (i.e. ticket or sponsorship) | ||
| /// @return durationSeconds The duration of the timelock in seconds | ||
| function _calculateTimelockDuration( |
There was a problem hiding this comment.
Inaccurate natspec docs for function signature
robsecord
reviewed
Sep 8, 2020
| /// @notice Calculates the early exit fee for the given amount | ||
| /// @param amount The amount of collateral to be withdrawn | ||
| /// @return Exit fee | ||
| function _calculateEarlyExitFee(address controlledToken, uint256 amount) internal view returns (uint256) { |
There was a problem hiding this comment.
Inaccurate natspec docs for function signature
robsecord
reviewed
Sep 8, 2020
| /// @param _principal The principal amount on which interest is accruing | ||
| /// @param _interest The amount of interest that must accrue | ||
| /// @return durationSeconds The duration of time it will take to accrue the given amount of interest, in seconds. | ||
| function estimateCreditAccrualTime( |
There was a problem hiding this comment.
missing '_controlledToken' from natspec docs
There was a problem hiding this comment.
most functions appear to be missing this param from natspec docs
robsecord
force-pushed
the
feature/pool-408-refactor-credit-accrual-into-prize-pool
branch
from
8e1f5db
to
1c36365
Compare
robsecord
changed the base branch from
version-3_rebased-onto_oz-audit_merged
to
oz-audit_merged
robsecord
deleted the
feature/pool-408-refactor-credit-accrual-into-prize-pool
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move credit accrual from the prize strategy into the prize pool.