Feature/pool 481 as an owner i want to remove external ERC20 awards #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robsecord
changed the title
asselstine
reviewed
Sep 10, 2020
| /// @param _prevExternalErc20 The address of the previous ERC20 token in the `externalErc20s` list. | ||
| /// If the ERC20 is the first address, then the previous address is the SENTINEL address: 0x0000000000000000000000000000000000000001 | ||
| function removeExternalErc20Award(address _externalErc20, address _prevExternalErc20) external onlyOwner { | ||
| require(externalErc20s.contains(_externalErc20), "PrizeStrategy/invalid-external-award"); |
There was a problem hiding this comment.
This condition is already indirectly enforced by this line in MappedSinglyLinkedList#removeAddress:
require(self.addressMap[prevAddress] == addr, "Invalid prevAddress");
I think we can remove the above require to save gas. Thoughts?
There was a problem hiding this comment.
It is enforced already, I agree. But the require statement is misleading in that case since 'addr' could be the invalid value. I guess we could update the require statement.
There was a problem hiding this comment.
Nevermind, I see what you did here -- it is assumed that the addr is known, and therefore it would be prevAddress that is incorrect..
asselstine
approved these changes
Sep 10, 2020
… of github.com:pooltogether/pooltogether-pool-contracts into feature/pool-481-as-an-owner-i-want-to-remove-external
robsecord
deleted the
feature/pool-481-as-an-owner-i-want-to-remove-external
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.