Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/pool 614 add controlledtokenbuilder #192

Merged
merged 1 commit into from Oct 7, 2020

Conversation

asselstine
Copy link
Contributor

No description provided.

@linear
Copy link

linear bot commented Oct 6, 2020

Copy link
Contributor

@robsecord robsecord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: this has breaking changes for both the Reference Pool Builder UI and the Subgraph (Prize Strategy events)

await expect(tx)
.to.emit(prizePool, 'ControlledTokenAdded')
.withArgs(
ticket.address
)

await prizePool.setPrizeStrategy(prizeStrategy.address)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could expect the PrizeStrategySet event

@asselstine asselstine force-pushed the feature/pool-614-add-controlledtokenbuilder branch from 4ff0dac to 683f1de Compare October 7, 2020 16:10
@robsecord robsecord merged commit 6405687 into version-3 Oct 7, 2020
@robsecord robsecord deleted the feature/pool-614-add-controlledtokenbuilder branch October 7, 2020 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants