Feature/pool 191 need a clearly defined way to create #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robsecord
reviewed
Jun 22, 2020
| SingleRandomWinnerPrizeStrategyFactory _prizeStrategyFactory | ||
| ) public initializer { | ||
| require(address(_prizePoolBuilder) != address(0), "prize pool builder must be defined"); | ||
| require(address(_rng) != address(0), "rng cannot be zero"); |
There was a problem hiding this comment.
The require statements should be consistent, would recommend "rng must be defined"
robsecord
reviewed
Jun 22, 2020
| @@ -53,10 +50,11 @@ abstract contract PeriodicPrizePool is Timelock, BaseRelayRecipient, ReentrancyG | |||
| event SponsorshipInterestMinted(address indexed operator, address indexed to, uint256 amount); | |||
| event SponsorshipInterestBurned(address indexed operator, address indexed from, uint256 amount); | |||
|
|
|||
| PrizeStrategyInterface public override prizeStrategy; | |||
| event Awarded(address indexed operator, address token, uint256 amount, bytes data); | |||
There was a problem hiding this comment.
address token could be indexed here
robsecord
reviewed
Jun 22, 2020
| @@ -695,7 +666,7 @@ abstract contract PeriodicPrizePool is Timelock, BaseRelayRecipient, ReentrancyG | |||
| // handle transfers of tickets, sponsorship, credits etc | |||
|
|
|||
| // transfers of credits are ignored | |||
| if (msg.sender == address(ticket)) { | |||
| if (msg.sender == address(__ticket)) { | |||
robsecord
reviewed
Jun 22, 2020
| event PrizePoolAwardStarted(address indexed operator, address indexed prizePool, uint256 indexed rngRequestId); | ||
|
|
||
| RNGInterface public rng; | ||
| mapping(address => uint256) rngRequestIds; |
There was a problem hiding this comment.
Missing access scope here
robsecord
reviewed
Jun 22, 2020
| } | ||
|
|
||
| function completeAward() public override requireCanCompleteAward nonReentrant { | ||
| function awardPrize() external override onlyPrizeStrategy returns (uint256) { | ||
| require(_isPrizePeriodOver(), "PeriodiPrizePool/not-over"); |
asselstine
deleted the
feature/pool-191-need-a-clearly-defined-way-to-create
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR splits the Prize Strategy more cleanly from the Prize Pool.