Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/pool 128 the prize strategy award arbitrary tokens #51

Merged

Conversation

asselstine
Copy link
Contributor

No description provided.

- Added ability for the PrizeStrategy to award arbitrary tokens held by
the PrizePool
- cTokens are restricted for the CompoundPrizePool
@linear
Copy link

linear bot commented Jul 7, 2020

POOL-128 The Prize Strategy should be able to award arbitrary tokens held by the Pool

So we'll need an award function for arbitrary tokens. However- the prize strategy cannot distribute blacklisted tokens. I.e. cTokens held by the periodic prize pool.

@asselstine asselstine changed the base branch from master to version-3 July 7, 2020 22:58
Copy link
Contributor

@robsecord robsecord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should double-check all require statements for consistency, as well as all usages of math equations to ensure we are using safe-math where applicable

contracts/prize-strategy/PrizeStrategy.sol Outdated Show resolved Hide resolved
contracts/prize-strategy/PrizeStrategy.sol Show resolved Hide resolved
test/CompoundPrizePool.test.js Outdated Show resolved Hide resolved
test/CompoundPrizePool.test.js Outdated Show resolved Hide resolved
test/CompoundPrizePool.test.js Outdated Show resolved Hide resolved
test/CompoundPrizePool.test.js Outdated Show resolved Hide resolved
contracts/prize-strategy/PrizeStrategy.sol Show resolved Hide resolved
contracts/prize-pool/PrizePool.sol Outdated Show resolved Hide resolved
contracts/prize-strategy/PrizeStrategy.sol Show resolved Hide resolved
contracts/prize-strategy/PrizeStrategy.sol Show resolved Hide resolved
@asselstine asselstine merged commit fd6e64a into version-3 Jul 9, 2020
@asselstine asselstine deleted the feature/pool-128-the-prize-strategy-should-be-able-to branch July 9, 2020 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants