feat(RNGChainlinkV2): add Chainlink VRF V2 #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PierrickGT
force-pushed
the
pool-1996-chainlink-20-implementation
branch
from
5e1682e
to
086757a
Compare
PierrickGT
force-pushed
the
pool-1996-chainlink-20-implementation
branch
from
086757a
to
1c0e920
Compare
asselstine
requested changes
Feb 4, 2022
contracts/RNGBlockhash.sol
Outdated
|
|
||
| import "./RNGInterface.sol"; | ||
| import "./interfaces/RNGInterface.sol"; |
There was a problem hiding this comment.
Keep in mind that this is a breaking change for any dependencies. Keep the same, even if it makes you twitch!
Try to touch as little as possible!
contracts/RNGChainlinkV2.sol
Outdated
| RequestConfig public sRequestConfig; | ||
|
|
||
| /// @notice Chainlink VRF subscription request id | ||
| uint256 public sRequestId; |
There was a problem hiding this comment.
We store the most recent Chainlink VRF request id to compare it with the request id passed to the fulfillRandomWords fallback function.
If it doesn't match, the transaction will revert.
contracts/RNGChainlinkV2.sol
Outdated
| _requestConfig.numWords | ||
| ); | ||
|
|
||
| sRequestId = _vrfRequestId; |
| sRequestConfig.keyHash = _keyhash; | ||
|
|
||
| emit KeyHashSet(_keyhash); | ||
| } |
There was a problem hiding this comment.
In addition to setting the keyhash, you'll want to add setters for each of the fields in RequestConfig.
Or you could just add a setRequestConfig function. It's prob easiest, even if info gets repeated. You already have a RequestConfigSet event too.
PierrickGT
force-pushed
the
pool-1996-chainlink-20-implementation
branch
from
21e2671
to
c1a3331
Compare
asselstine
approved these changes
Feb 4, 2022
PierrickGT
force-pushed
the
pool-1996-chainlink-20-implementation
branch
from
c1a3331
to
35cdaf9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.