Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed redundant approve #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

asselstine
Copy link

No description provided.

@linear
Copy link

linear bot commented Jul 20, 2021

POOL-1357 Remove redundant approve in Yearn yield source

This line:

if (_token.allowance(address(this), address(v)) < _token.balanceOf(address(this))) {

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1050025239

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.8%) to 98.039%

Totals Coverage Status
Change from base Build 1035696203: 1.8%
Covered Lines: 76
Relevant Lines: 76

💛 - Coveralls

@PierrickGT PierrickGT self-assigned this Jul 20, 2021
@@ -225,10 +225,6 @@ contract YearnV2YieldSource is IYieldSource, ERC20Upgradeable, OwnableUpgradeabl
IYVaultV2 v = vault; // NOTE: for gas usage
IERC20Upgradeable _token = token;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove this unused variable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants