reduce SLOAD calls in _depositInVault #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PierrickGT
suggested changes
Jun 30, 2021
Comment on lines
171
to
172
| IERC20Upgradeable _token = token; | ||
| if(_token.allowance(address(this), address(v)) < _token.balanceOf(address(this))) { |
There was a problem hiding this comment.
Add some space
Suggested change
| IERC20Upgradeable _token = token; | |
| if(_token.allowance(address(this), address(v)) < _token.balanceOf(address(this))) { | |
| IERC20Upgradeable _token = token; | |
| if (_token.allowance(address(this), address(v)) < _token.balanceOf(address(this))) { |
| token.safeApprove(address(v), type(uint256).max); | ||
| IERC20Upgradeable _token = token; | ||
| if(_token.allowance(address(this), address(v)) < _token.balanceOf(address(this))) { | ||
| _token.safeApprove(address(v), type(uint256).max); |
There was a problem hiding this comment.
We should do this in initialize, this way we wouldn't have to write all this if.
There was a problem hiding this comment.
That's covered here: code-423n4/2021-06-pooltogether-findings#95
| if(maxLosses != 0) { | ||
| vault.withdraw(yShares, address(this), maxLosses); | ||
| uint256 _maxLosses = maxLosses; | ||
| if(_maxLosses != 0) { |
There was a problem hiding this comment.
Add a space
Suggested change
| if(_maxLosses != 0) { | |
| if (_maxLosses != 0) { |
|
As a side note that should be addressed in another PR, we don't need to Which would avoid us doing this check: Fixed in this PR: #8 |
|
Not sure if it will lower gas consumption since |
asselstine
approved these changes
Jul 5, 2021
| token.safeApprove(address(v), type(uint256).max); | ||
| IERC20Upgradeable _token = token; | ||
| if(_token.allowance(address(this), address(v)) < _token.balanceOf(address(this))) { | ||
| _token.safeApprove(address(v), type(uint256).max); |
There was a problem hiding this comment.
That's covered here: code-423n4/2021-06-pooltogether-findings#95
asselstine
approved these changes
Jul 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
code-423n4/2021-06-pooltogether-findings#44