fix(contract): approve max amount in constructor

pooltogether · Jul 8, 2021 · e54d56d · e54d56d
1 parent 952ea8f
commit e54d56d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 7 deletions.
diff --git a/contracts/SushiYieldSource.sol b/contracts/SushiYieldSource.sol
@@ -47,11 +47,8 @@ contract SushiYieldSource is IYieldSource {
 
         sushiBar = _sushiBar;
         sushiAddr = _sushiAddr;
-    }
 
-    /// @notice Approve SUSHI to spend infinite sushiBar (xSUSHI)
-    function intialize() external {
-        sushiAddr.safeApprove(address(sushiBar), type(uint256).max);
+        _sushiAddr.safeApprove(address(_sushiBar), type(uint256).max);
     }
 
     /// @notice Returns the ERC20 asset token used for deposits.
@@ -76,7 +73,6 @@ contract SushiYieldSource is IYieldSource {
     /// @param to The user whose balance will receive the tokens
     function supplyTokenTo(uint256 amount, address to) external override {
         sushiAddr.safeTransferFrom(msg.sender, address(this), amount);
-        sushiAddr.safeApprove(address(sushiBar), amount);
 
         ISushiBar bar = sushiBar;
         uint256 beforeBalance = bar.balanceOf(address(this));

diff --git a/test/unit_test.js b/test/unit_test.js
@@ -36,6 +36,7 @@ describe("SushiYieldSource", function () {
       wallet,
       overrides
     );
+
     sushi = await ERC20MintableContract.deploy("Sushi", "SUSHI");
 
     const SushiBarContract = await hre.ethers.getContractFactory(
@@ -50,11 +51,11 @@ describe("SushiYieldSource", function () {
     );
 
     if (!isDeployTest) {
-      deploySushiYieldSource(sushiBar.address, sushi.address);
+      await deploySushiYieldSource(sushiBar.address, sushi.address);
     }
 
     amount = toWei("100");
-    await yieldSource.intialize()
+
     await sushi.mint(wallet.address, amount);
     await sushi.mint(wallet2.address, amount.mul(99));
     await sushi.connect(wallet2).approve(sushiBar.address, amount.mul(99));