Skip to content

Commit

Permalink
PR comments
Browse files Browse the repository at this point in the history
  • Loading branch information
asselstine committed Oct 6, 2021
1 parent fd501bd commit 4eec773
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
4 changes: 2 additions & 2 deletions contracts/DrawBeacon.sol
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ contract DrawBeacon is IDrawBeacon, Ownable {
}

/// @inheritdoc IDrawBeacon
function calculateNextBeaconPeriodStartTime(uint256 _time)
function calculateNextBeaconPeriodStartTime(uint256 _currentTime)
external
view
override
Expand All @@ -201,7 +201,7 @@ contract DrawBeacon is IDrawBeacon, Ownable {
_calculateNextBeaconPeriodStartTime(
beaconPeriodStartedAt,
beaconPeriodSeconds,
uint64(_time)
uint64(_currentTime)
);
}

Expand Down
10 changes: 5 additions & 5 deletions contracts/prize-strategy/PrizeSplit.sol
Original file line number Diff line number Diff line change
Expand Up @@ -83,25 +83,25 @@ abstract contract PrizeSplit is IPrizeSplit, Ownable {
}

/// @inheritdoc IPrizeSplit
function setPrizeSplit(PrizeSplitConfig memory _prizeStrategySplit, uint8 _prizeSplitIndex)
function setPrizeSplit(PrizeSplitConfig memory _prizeSplit, uint8 _prizeSplitIndex)
external
override
onlyOwner
{
require(_prizeSplitIndex < _prizeSplits.length, "PrizeSplit/nonexistent-prizesplit");
require(_prizeStrategySplit.target != address(0), "PrizeSplit/invalid-prizesplit-target");
require(_prizeSplit.target != address(0), "PrizeSplit/invalid-prizesplit-target");

// Update the prize split config
_prizeSplits[_prizeSplitIndex] = _prizeStrategySplit;
_prizeSplits[_prizeSplitIndex] = _prizeSplit;

// Total prize split do not exceed 100%
uint256 totalPercentage = _totalPrizeSplitPercentageAmount();
require(totalPercentage <= 1000, "PrizeSplit/invalid-prizesplit-percentage-total");

// Emit updated prize split config
emit PrizeSplitSet(
_prizeStrategySplit.target,
_prizeStrategySplit.percentage,
_prizeSplit.target,
_prizeSplit.percentage,
_prizeSplitIndex
);
}
Expand Down

0 comments on commit 4eec773

Please sign in to comment.