Merge pull request #189 from pooltogether/pool-1705-drawcalculatormat…

…chcardinality-needs-to added matchCardinality gt 0 check
pooltogether · Oct 6, 2021 · 7a7e22a · 7a7e22a
2 parents 8906897 + e5ab5b7
commit 7a7e22a
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/contracts/PrizeDistributionHistory.sol b/contracts/PrizeDistributionHistory.sol
@@ -178,8 +178,9 @@ contract PrizeDistributionHistory is IPrizeDistributionHistory, Manageable {
         uint32 _drawId,
         DrawLib.PrizeDistribution calldata _prizeDistribution
     ) internal returns (bool) {
+
         require(_drawId > 0, "DrawCalc/draw-id-gt-0");
-
+        require(_prizeDistribution.matchCardinality > 0, "DrawCalc/matchCardinality-gt-0");
         require(
             _prizeDistribution.bitRangeSize <= 256 / _prizeDistribution.matchCardinality,
             "DrawCalc/bitRangeSize-too-large"

diff --git a/test/PrizeDistributionHistory.test.ts b/test/PrizeDistributionHistory.test.ts
@@ -193,6 +193,14 @@ describe('PrizeDistributionHistory', () => {
                 ).to.be.revertedWith('DrawCalc/bitRangeSize-gt-0');
             });
 
+            it('cannot set matchCardinality = 0', async () => {
+                prizeDistribution.matchCardinality = BigNumber.from(0);
+
+                await expect(
+                    prizeDistributionHistory.pushPrizeDistribution(1, prizeDistribution),
+                ).to.be.revertedWith('DrawCalc/matchCardinality-gt-0');
+            });
+
             it('cannot set maxPicksPerUser = 0', async () => {
                 prizeDistribution.maxPicksPerUser = BigNumber.from(0);