fix(GaugeReward): always emit RewardsClaimed event

pooltogether · Aug 10, 2022 · c15be96 · c15be96
1 parent 8641489
commit c15be96
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/contracts/GaugeReward.sol b/contracts/GaugeReward.sol
@@ -461,9 +461,9 @@ contract GaugeReward is IGaugeReward, IPrizePoolLiquidatorListener, Multicall {
 
         if (_rewards > 0) {
             userRewardTokenBalances[_user][_rewardToken.token] += _rewards;
-            emit RewardsClaimed(_gauge, _rewardToken.token, _user, _rewards, _exchangeRate);
         }
 
+        emit RewardsClaimed(_gauge, _rewardToken.token, _user, _rewards, _exchangeRate);
         return _rewards;
     }
 

diff --git a/test/GaugeReward.test.ts b/test/GaugeReward.test.ts
@@ -730,7 +730,7 @@ describe('GaugeReward', () => {
                 .returns(userStakeBalance);
 
             expect(await gaugeReward.claimAll(gaugeAddress, owner.address))
-                .to.not.emit(gaugeReward, 'RewardsClaimed')
+                .to.emit(gaugeReward, 'RewardsClaimed')
                 .withArgs(
                     gaugeAddress,
                     poolToken.address,
@@ -756,7 +756,7 @@ describe('GaugeReward', () => {
                 .returns(userStakeBalance);
 
             expect(await gaugeReward.claimAll(gaugeAddress, owner.address))
-                .to.not.emit(gaugeReward, 'RewardsClaimed')
+                .to.emit(gaugeReward, 'RewardsClaimed')
                 .withArgs(
                     gaugeAddress,
                     poolToken.address,