number of picks uint64 (#191)

Co-authored-by: Aodhgan <aodhgan@pooltogether.com>
pooltogether · Oct 6, 2021 · e12a86a · e12a86a
1 parent 20dcc52
commit e12a86a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/contracts/DrawCalculator.sol b/contracts/DrawCalculator.sol
@@ -142,7 +142,7 @@ contract DrawCalculator is IDrawCalculator, Ownable {
             _prizeDistributions
         );
 
-        uint256 totalUserPicks = _calculateNumberOfUserPicks(
+        uint64 totalUserPicks = _calculateNumberOfUserPicks(
             _prizeDistributions[0],
             userBalances[0]
         );
@@ -196,7 +196,7 @@ contract DrawCalculator is IDrawCalculator, Ownable {
 
         // calculate prizes awardable for each Draw passed
         for (uint32 drawIndex = 0; drawIndex < _draws.length; drawIndex++) {
-            uint256 totalUserPicks = _calculateNumberOfUserPicks(
+            uint64 totalUserPicks = _calculateNumberOfUserPicks(
                 _prizeDistributions[drawIndex],
                 _normalizedUserBalances[drawIndex]
             );
@@ -223,8 +223,8 @@ contract DrawCalculator is IDrawCalculator, Ownable {
     function _calculateNumberOfUserPicks(
         DrawLib.PrizeDistribution memory _prizeDistribution,
         uint256 _normalizedUserBalance
-    ) internal pure returns (uint256) {
-        return (_normalizedUserBalance * _prizeDistribution.numberOfPicks) / 1 ether;
+    ) internal pure returns (uint64) {
+        return uint64((_normalizedUserBalance * _prizeDistribution.numberOfPicks) / 1 ether);
     }
 
     /**

diff --git a/contracts/test/DrawCalculatorHarness.sol b/contracts/test/DrawCalculatorHarness.sol
@@ -51,7 +51,7 @@ contract DrawCalculatorHarness is DrawCalculator {
     function calculateNumberOfUserPicks(
         DrawLib.PrizeDistribution memory _prizeDistribution,
         uint256 _normalizedUserBalance
-    ) external pure returns (uint256) {
+    ) external pure returns (uint64) {
         return _calculateNumberOfUserPicks(_prizeDistribution, _normalizedUserBalance);
     }
 }