Renamed DrawPrize to PrizeDistributor #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PierrickGT
suggested changes
Oct 6, 2021
asselstine
force-pushed
the
pool-1718-rename-drawprize-to-prizedistributor
branch
from
9551abe
to
f955bbd
Compare
PierrickGT
reviewed
Oct 6, 2021
| @@ -211,10 +211,10 @@ describe('PrizeDistributionHistory', () => { | |||
| }); | |||
|
|
|||
| it('should fail to create a new draw when called from non-draw-manager', async () => { | |||
| const drawPrizeWallet2 = prizeDistributionHistory.connect(wallet2); | |||
| const prizeDistributorWallet2 = prizeDistributionHistory.connect(wallet2); | |||
There was a problem hiding this comment.
These changes will conflict with the following PR: #205
So need to make sure we do rename in PrizeDistributionBuffer.test.ts.
PierrickGT
approved these changes
Oct 6, 2021
asselstine
restored the
pool-1718-rename-drawprize-to-prizedistributor
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.