update(RingBuffers): add getBufferCardinality to DrawHistory/PrizeDistributionHistory #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PierrickGT
suggested changes
Oct 6, 2021
test/DrawHistory.test.ts
Outdated
| @@ -39,6 +39,13 @@ describe('DrawHistory', () => { | |||
| await drawHistory.setManager(wallet1.address); | |||
| }); | |||
|
|
|||
| describe.only('getBufferCardinality()', () => { | |||
There was a problem hiding this comment.
Suggested change
| describe.only('getBufferCardinality()', () => { | |
| describe('getBufferCardinality()', () => { |
Comment on lines
138
to
141
| // @TODO: Create PrizeDistributionHistory harness smart contract to expose | ||
| describe('_estimateDrawId()', () => { | ||
| it('should return Draw ID 0 when no history', async () => {}); | ||
| it('should return Draw ID 0 when no history', async () => { }); | ||
| }); |
There was a problem hiding this comment.
Should we remove or add this test?
|
Let's get this done- should be merged before the name change PR |
asselstine
requested changes
Oct 6, 2021
| @@ -130,7 +137,7 @@ describe('PrizeDistributionHistory', () => { | |||
|
|
|||
| // @TODO: Create PrizeDistributionHistory harness smart contract to expose | |||
| describe('_estimateDrawId()', () => { | |||
| it('should return Draw ID 0 when no history', async () => {}); | |||
| it('should return Draw ID 0 when no history', async () => { }); | |||
| }); | |||
PierrickGT
approved these changes
Oct 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds function to get ring buffer cardinality