Optimized mask creation in draw calc #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PierrickGT
approved these changes
Oct 14, 2021
contracts/DrawCalculator.sol
Outdated
| for (uint8 maskIndex = 0; maskIndex < _prizeDistribution.matchCardinality; maskIndex++) { | ||
| // create mask of width bitRangeSize bits at index | ||
| uint256 _matchIndexOffset = uint256(maskIndex) * uint256(_prizeDistribution.bitRangeSize); | ||
| if(_prizeDistribution.matchCardinality == 0) return masks; |
There was a problem hiding this comment.
Suggested change
| if(_prizeDistribution.matchCardinality == 0) return masks; | |
| if (_prizeDistribution.matchCardinality == 0) { | |
| return masks; | |
| } |
There was a problem hiding this comment.
matchCardinality cannot be 0 so removing this
asselstine
deleted the
pool-1787-gas-bitmasks-creation-can-be-simplified
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: code-423n4/2021-10-pooltogether-findings#21