Simplified Liquidator #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
asselstine
commented
May 19, 2022
asselstine
commented
- User now sets an arb target and max slippage
- whenever user wants to swap, first it runs a buyback then swaps.
- User now sets an arb target and max slippage - whenever user wants to swap, first it runs a buyback then swaps.
PierrickGT
approved these changes
May 19, 2022
ArbTarget.md
Outdated
| @@ -0,0 +1,22 @@ | |||
| Slippage: 5% | |||
There was a problem hiding this comment.
Add this file to the docs or in Notion. Very informative but it doesn't really have it's place in this repo.
contracts/PrizePoolLiquidator.sol
Outdated
| }); | ||
| return true; | ||
| } | ||
|
|
||
| function setPrizePoolLiquidationState(IPrizePool _prizePool, int256 deltaRatePerSecond, int256 maxSlippage) external { | ||
| poolLiquidatorStates[_prizePool].deltaRatePerSecond = PRBMath.SD59x18(deltaRatePerSecond); | ||
| function setPrizePoolLiquidationState(IPrizePool _prizePool, int256 maxSlippage) external { |
There was a problem hiding this comment.
Suggested change
| function setPrizePoolLiquidationState(IPrizePool _prizePool, int256 maxSlippage) external { | |
| function setPrizePoolLiquidationState(IPrizePool _prizePool, int256 _maxSlippage) external { |
| }) | ||
|
|
||
| it('should revert if there is insufficient balance', async () => { | ||
| await expect(liquidatorLibHarness.swapExactAmountOutAtTime(toWei('50'), toWei('100'), '10')) | ||
| await expect(liquidatorLibHarness.swapExactAmountOut(toWei('50'), toWei('100'))) |
There was a problem hiding this comment.
Would be great to test for slippage too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.