feat(tests): add GaugeReward unit tests #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asselstine
requested changes
May 26, 2022
test/TokenVault.test.ts
Outdated
| await token.mock.approve.withArgs(wallet2.address, '1111').returns(true) | ||
| await vault.increaseERC20Allowance(token.address, wallet2.address, '1111') | ||
| await tokenVault.increaseERC20Allowance(token.address, wallet2.address, '1111') |
There was a problem hiding this comment.
You know what is interesting about this test- is that it doesn't assert the state change.
The mock doesn't have an expectation, so if the mock isn't called this test will still pass.
In this case, the easiest thing would be to instantiate a real token and check to see that the allowance was changed properly
test/TokenVault.test.ts
Outdated
| await token.mock.approve.withArgs(wallet2.address, '1111').returns(true) | ||
| await vault.connect(wallet3).increaseERC20Allowance(token.address, wallet2.address, '1111') | ||
| await tokenVault.connect(wallet3).increaseERC20Allowance(token.address, wallet2.address, '1111') |
test/TokenVault.test.ts
Outdated
| await token.mock.approve.withArgs(wallet2.address, '111').returns(true) | ||
| await vault.decreaseERC20Allowance(token.address, wallet2.address, '1000') | ||
| await tokenVault.decreaseERC20Allowance(token.address, wallet2.address, '1000') |
test/TokenVault.test.ts
Outdated
| await token.mock.approve.withArgs(wallet2.address, '0').returns(true) | ||
| await vault.connect(wallet3).decreaseERC20Allowance(token.address, wallet2.address, '1111') | ||
| await tokenVault.connect(wallet3).decreaseERC20Allowance(token.address, wallet2.address, '1111') |
test/TokenVault.test.ts
Outdated
| await token.mock.approve.withArgs(wallet2.address, '0').returns(true) | ||
| await vault.connect(wallet3).decreaseERC20Allowance(token.address, wallet2.address, '1111') | ||
| await tokenVault.connect(wallet3).decreaseERC20Allowance(token.address, wallet2.address, '1111') | ||
| }) |
There was a problem hiding this comment.
how about some revert checks for non-owner/managers?
PierrickGT
force-pushed
the
pool-2266-migrate-gaugereward-add-tests-bis
branch
from
5a61ae4
to
38cb693
Compare
PierrickGT
force-pushed
the
pool-2266-migrate-gaugereward-add-tests-bis
branch
from
38cb693
to
181e3c7
Compare
asselstine
approved these changes
May 27, 2022
PierrickGT
force-pushed
the
pool-2266-migrate-gaugereward-add-tests-bis
branch
from
b945745
to
4e1d4ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.