Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GaugeController: Add Owner and Manager Roles #279

Merged
merged 6 commits into from
Jun 2, 2022
Merged

GaugeController: Add Owner and Manager Roles #279

merged 6 commits into from
Jun 2, 2022

Conversation

kamescg
Copy link
Contributor

@kamescg kamescg commented Jun 1, 2022

No description provided.

@kamescg kamescg requested a review from PierrickGT June 1, 2022 21:50
@kamescg kamescg self-assigned this Jun 1, 2022
@linear
Copy link

linear bot commented Jun 1, 2022

POOL-2294 GaugeController: Add Authorization Roles and Unit Tests

@kamescg kamescg marked this pull request as ready for review June 1, 2022 22:05
@kamescg kamescg requested a review from asselstine June 1, 2022 22:06
PierrickGT
PierrickGT suggested changes Jun 1, 2022
View reviewed changes
Copy link
Contributor

@PierrickGT PierrickGT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just need to add a couple tests for the manager role and also remove the /// @TODO: Add Governance/Executive authorization modifier/function. comments.

test/GaugeController.test.ts Show resolved Hide resolved
test/GaugeController.test.ts Show resolved Hide resolved
test/GaugeController.test.ts Show resolved Hide resolved
asselstine
asselstine requested changes Jun 2, 2022
View reviewed changes
contracts/GaugeController.sol Outdated Show resolved Hide resolved
contracts/GaugeController.sol Outdated Show resolved Hide resolved
contracts/GaugeController.sol Outdated Show resolved Hide resolved
@kamescg kamescg merged commit f68718a into staging Jun 2, 2022
@kamescg kamescg deleted the pool-2294-gaugecontroller-add-authorization-roles branch June 2, 2022 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PierrickGT PierrickGT PierrickGT requested changes

@asselstine asselstine asselstine requested changes

Assignees

@kamescg kamescg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kamescg @PierrickGT @asselstine