Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update events to enable TWAB tracking on subgraphs #4

Merged
merged 4 commits into from
Mar 22, 2023

Conversation

dylandesrosier
Copy link
Contributor

No description provided.

@linear
Copy link

linear bot commented Mar 21, 2023

POOL-2645 Twab Updates

  • Replace NewUserTwab with IncreasedBalance and DecreasedBalance. Each of which should have the increase amounts, as well as the new twab and whether the twab is new
  • Replace NewTotalSupplyTwab with IncreasedTotalSupply and DecreasedTotalSupply (as above) and always emit

@github-actions
Copy link

LCOV of commit c10b608 during coverage #51

Summary coverage rate:
  lines......: 74.1% (140 of 189 lines)
  functions..: 72.3% (34 of 47 functions)
  branches...: no data found

Files changed coverage rate:
                                             |Lines       |Functions  |Branches    
  Filename                                   |Rate     Num|Rate    Num|Rate     Num
  =================================================================================
  src/TwabController.sol                     | 100%     80| 100%    25|    -      0

⛔ The code coverage is too low. Expected at least 90.

@github-actions
Copy link

LCOV of commit 551d6db during coverage #53

Summary coverage rate:
  lines......: 74.1% (140 of 189 lines)
  functions..: 72.3% (34 of 47 functions)
  branches...: no data found

Files changed coverage rate:
                                             |Lines       |Functions  |Branches    
  Filename                                   |Rate     Num|Rate    Num|Rate     Num
  =================================================================================
  src/TwabController.sol                     | 100%     80| 100%    25|    -      0

⛔ The code coverage is too low. Expected at least 90.

Copy link
Contributor

@asselstine asselstine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need both of amount and delegatedAmount

@github-actions
Copy link

LCOV of commit ae709e6 during coverage #56

Summary coverage rate:
  lines......: 80.2% (146 of 182 lines)
  functions..: 81.0% (34 of 42 functions)
  branches...: no data found

Files changed coverage rate:
                                             |Lines       |Functions  |Branches    
  Filename                                   |Rate     Num|Rate    Num|Rate     Num
  =================================================================================
  src/TwabController.sol                     | 100%     80| 100%    25|    -      0
  src/libraries/ObservationLib.sol           | 0.0%     16| 0.0%     1|    -      0
  src/libraries/TwabLib.sol                  | 100%     66| 100%     9|    -      0

⛔ The code coverage is too low. Expected at least 90.

@dylandesrosier dylandesrosier merged commit 722b177 into main Mar 22, 2023
@PierrickGT PierrickGT deleted the pool-2645-twab-updates branch March 29, 2023 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants