Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix quest type filter width #49

Closed
wants to merge 2 commits into from
Closed

Fix quest type filter width #49

wants to merge 2 commits into from

Conversation

gakada
Copy link
Contributor

@gakada gakada commented Jun 5, 2018

Since English strings can be longer
1
vs
2

@KagamiChan
Copy link
Member

Seems we could simply omit the redundant QUEST for each category selection

@gakada
Copy link
Contributor Author

gakada commented Jun 7, 2018

On Lumendark skin that is still (without Quest)
u
So maybe both drop Quest and increase the width just a bit?

@KagamiChan
Copy link
Member

KagamiChan commented Jun 7, 2018

Feel free to replace all occurrences of QUEST, e.g. replace all Composition Quest with Composition

@gakada
Copy link
Contributor Author

gakada commented Jun 7, 2018

I did cedb151 and afab0c9. Or you want to switch "Composition Quest" keys to "Composition"/etc., that would require editing i18n files for all languages as well as index.es.

@KagamiChan
Copy link
Member

I'll go with the latter because we could remove the redundant quest from the origin, which is more definitive

@KagamiChan
Copy link
Member

A project scope "find and replace" could make this in either VS Code or Atom. Or you could leave it to me if you use another editor

@gakada
Copy link
Contributor Author

gakada commented Jun 7, 2018

I'm using VS Code, I was just choosing between the two, the latter one is OK too.

@gnattu
Copy link
Member

gnattu commented Jun 7, 2018

This does not seems to be a plugin or translation issue to me. This only happen to certain themes, because those themes uppercases all button texts, which makes the text significantly wider and exceeds the edge of the button.

LumenDark with default uppercase:
screen shot 2018-06-08 at 00 54 33

LumenDark without uppercase:
screen shot 2018-06-08 at 00 54 46

@gakada
Copy link
Contributor Author

gakada commented Jun 7, 2018

Still looks like this with no uppercase to me (paperdark)
u

@KagamiChan
Copy link
Member

@gnattu anyway the quest could be removed to leave some space, at least that's not bad

@gakada
Copy link
Contributor Author

gakada commented Jun 7, 2018

Going to reopen.

@gakada gakada closed this Jun 7, 2018
@gakada gakada deleted the layout branch August 28, 2018 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants