Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/data #66

Merged
merged 4 commits into from
Jan 22, 2021
Merged

Chore/data #66

merged 4 commits into from
Jan 22, 2021

Conversation

lawvs
Copy link
Contributor

@lawvs lawvs commented Jan 21, 2021

Try to use translations from kcanotify-gamedata

Translation data for ships, equipments and quest are mainly from kc3-translations.
License for kc3-translations: The MIT License Text
--kcanotify

Thanks to KC3Kai/kc3-translations and @XxJimmy122xX for their work!

Changelog

v0.8.0 (2021-01-21)

Data

  • Fix B144 type
  • Update draft

Features

  • Add kcanotify translation
  • Export kcanotifyTranslation

Breaking Changes

  • Prefer to use kcanotify translation
  • Add 0(Unknown) on Quest.category type

@KagamiChan
Copy link
Member

If we stop using the quest object, can we download the data directly in this repo? in this way there's no delay for package release process

@KagamiChan
Copy link
Member

I'm neutral for this change, just want to explore some possibilities to ship timely the new data

@XxJimmy122xX
Copy link

kcanotify-gamedata is also used for Kcanotify to update in-app data. So it will always be up-to-date. Updates for new tasks useally take a day to a week. If you want faster update (like hours within task release), feel free to find me.

@KagamiChan
Copy link
Member

KagamiChan commented Jan 21, 2021

Thanks @XxJimmy122xX, to avoid confusion, let me explain a little bit

From my understanding current process is:

  1. kcwiki-quest-data downloads kcanotify-gamedata for translation
  2. kcwiki-quest-data updates other quest info
  3. new kcwiki-quest-data release
  4. poi-plugin-quest updates kcwiki-quest-data
  5. poi-plugin-quest release

What I want to optimize is the step 1, 3 and 4, as translation and quest reward/requirement is not depending each other now, poi-plugin-quest can download the kcanotify-gamedata and kcwiki-quest-data separately. In this way we'll show what's avaialble and no one needs to hurry

@lawvs
Copy link
Contributor Author

lawvs commented Jan 21, 2021

If we stop using the quest object, can we download the data directly in this repo? in this way there's no delay for package release process

Structured data is too complex to maintain (I haven't found any other i18n data source that has been maintained before), I'm planning to abandon kcwiki-quest-data and use kcanotify-gamedata on plugin-quest directly.

If switching to use kcanotify-gamedata then there are several questions:

  • Whether kcanotify-gamedata can be updated continuously
  • We will lose most of the quest reward information
  • We will lose structured information (hardly ever used)

@lawvs
Copy link
Contributor Author

lawvs commented Jan 21, 2021

I forgot to specify that this update focuses on translations for poi's task-panel

image

@KagamiChan
Copy link
Member

It is OK that we stop using the old quest data structure since it has become sophiscated and hard to maintain. I won't have any bad feelings for that.

To step forward, we can use a simpler structure for holding rewards and maybe quest dependencies

@KagamiChan KagamiChan merged commit bcae98c into poooi:master Jan 22, 2021
@lawvs lawvs deleted the chore/data branch January 22, 2021 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants