warning: this expression creates a reference which is immediately dereferenced by the compiler --> cosmic-applet-audio/src/mpris_subscription.rs:159:45 | 159 | players.sort_by(|a, b| a.name().cmp(&b.name())); | ^^^^^^^^^ help: change this to: `b.name()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default

warning: this expression creates a reference which is immediately dereferenced by the compiler --> cosmic-applet-audio/src/mpris_subscription.rs:183:50 | 183 | self.players.sort_by(|a, b| a.name().cmp(&b.name())); | ^^^^^^^^^ help: change this to: `b.name()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: the following explicit lifetimes could be elided: 'a --> cosmic-applet-audio/src/mpris_subscription.rs:274:22 | 274 | async fn find_active<'a>(players: &'a Vec<MprisPlayer>) -> Option<&'a MprisPlayer> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes = note: `#[warn(clippy::needless_lifetimes)]` on by default

warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do --> cosmic-applet-audio/src/mpris_subscription.rs:274:35 | 274 | async fn find_active<'a>(players: &'a Vec<MprisPlayer>) -> Option<&'a MprisPlayer> { | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&'a [MprisPlayer]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg = note: `#[warn(clippy::ptr_arg)]` on by default

warning: very complex type used. Consider factoring parts into `type` definitions --> cosmic-applet-audio/src/pulse.rs:27:24 | 27 | pub static FROM_PULSE: Lazy<Mutex<Option<(mpsc::Receiver<Message>, mpsc::Sender<Message>)>>> = | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity = note: `#[warn(clippy::type_complexity)]` on by default

warning: non-binding `let` on a future --> cosmic-applet-audio/src/lib.rs:456:25 | 456 | / _ = tokio::spawn(async move { 457 | | tokio::time::sleep(tokio::time::Duration::from_secs(30)).await; 458 | | conn.send(pulse::Message::UpdateConnection); 459 | | }); | |__________________________^ | = help: consider awaiting the future or dropping explicitly with `std::mem::drop` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_future = note: `#[warn(clippy::let_underscore_future)]` on by default

warning: this `else { if .. }` block can be collapsed --> cosmic-applet-bluetooth/src/bluetooth.rs:622:40 | 622 | ... } else { | ______________________________^ 623 | | ... if let Err(err) = device.set_trusted(true).await { 624 | | ... tracing::error!(?err, "Failed to trust device."); 625 | | ... } 626 | | ... } | |_______________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_else_if = note: `#[warn(clippy::collapsible_else_if)]` on by default help: collapse nested if block | 622 ~ } else if let Err(err) = device.set_trusted(true).await { 623 + tracing::error!(?err, "Failed to trust device."); 624 + } |

warning: this `else { if .. }` block can be collapsed --> cosmic-applet-bluetooth/src/bluetooth.rs:637:40 | 637 | ... } else { | ______________________________^ 638 | | ... if let Err(err) = device.set_trusted(true).await { 639 | | ... tracing::error!(?err, "Failed to trust device."); 640 | | ... } 641 | | ... } | |_______________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_else_if help: collapse nested if block | 637 ~ } else if let Err(err) = device.set_trusted(true).await { 638 + tracing::error!(?err, "Failed to trust device."); 639 + } |

warning: variant `OpenSettings` is never constructed --> cosmic-applet-bluetooth/src/app.rs:78:5 | 68 | enum Message { | ------- variant in this enum ... 78 | OpenSettings, | ^^^^^^^^^^^^ | = note: `Message` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis = note: `#[warn(dead_code)]` on by default