Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cosmic-screencopy-v2 #358

Merged
merged 1 commit into from
Mar 25, 2024
Merged

cosmic-screencopy-v2 #358

merged 1 commit into from
Mar 25, 2024

Conversation

Drakulix
Copy link
Member

@Drakulix Drakulix commented Mar 15, 2024 •
edited
Loading

Fixes #338

@Drakulix
Copy link
Member Author

Seems to work in combination with pop-os/xdg-desktop-portal-cosmic#31 now.

We still need to update cosmic-workspaces and cosmic-applet-minimize.

@Drakulix Drakulix changed the title ext-screencopy-v2 cosmic-screencopy-v2 Mar 18, 2024
@Drakulix Drakulix mentioned this pull request Mar 18, 2024
Draft
@ids1024
Copy link
Member

ids1024 commented Mar 21, 2024

Hm, I'm sure it was working when I tried it earlier, but now (on a different computer, with multiple monitors; though that may not be relevant), I'm seeing cosmic-screenshot hang with pop-os/xdg-desktop-portal-cosmic#31.

WAYLAND_DEBUG shows xdg-desktop-portal-cosmic not getting any response after calling capture on zcosmic_screencopy_frame_v2, to capture an output.

pop-os/cosmic-workspaces-epoch#21 (which uses workspace capture, not output capture) seems to be working pretty well though.

@Drakulix
Copy link
Member Author

Hm, I'm sure it was working when I tried it earlier, but now (on a different computer, with multiple monitors; though that may not be relevant), I'm seeing cosmic-screenshot hang with pop-os/xdg-desktop-portal-cosmic#31.

WAYLAND_DEBUG shows xdg-desktop-portal-cosmic not getting any response after calling capture on zcosmic_screencopy_frame_v2, to capture an output.

pop-os/cosmic-workspaces-epoch#21 (which uses workspace capture, not output capture) seems to be working pretty well though.

I'll try to reproduce it, but since you seem to have a setup where this is broken, could you step through the compositor code to see where it goes wrong?

ids1024
ids1024 approved these changes Mar 22, 2024
View reviewed changes
Copy link
Member

@ids1024 ids1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems to be working well now.

@Drakulix Drakulix marked this pull request as ready for review March 25, 2024 15:01
@Drakulix Drakulix merged commit b40d153 into master Mar 25, 2024
3 checks passed
@Drakulix Drakulix deleted the ext-screencopy-v2_jammy branch March 25, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ids1024 ids1024 ids1024 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OnDamage screencopy issues
2 participants
@Drakulix @ids1024